Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Space key from keyboard navigation on #267

Merged
merged 3 commits into from
May 19, 2016
Merged

Remove the Space key from keyboard navigation on #267

merged 3 commits into from
May 19, 2016

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented May 19, 2016 •
edited
Loading

Fixes #265. Remove the Space key from keyboard navigation on DropMenu.

PR Checklist

  • Manually tested across supported browsers
    • Chrome
    • Firefox
    • Safari
    • IE11 (Win 7)
    • Edge (Win 10)
  • Unit tests written (common at minimum)
  • PR has one of the semver- labels
  • Two core team engineer approvals
  • One core team UX approval

@ogupte ogupte added this to the 1.0.0 milestone May 19, 2016
@ogupte ogupte self-assigned this May 19, 2016
@ogupte ogupte changed the title Fixes issue #265. Remove the Space key from keyboard navigation on Remove the Space key from keyboard navigation on May 19, 2016
@ogupte ogupte merged commit a03c55d into release/1.0.0 May 19, 2016
@ogupte ogupte deleted the quality/DropMenu-no-space-key-capture branch May 19, 2016 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ogupte ogupte

Labels
quality semver-minor
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ogupte @sodiumjoe @jondlm